[rfa] one-liner in lex.c

[Zack Weinberg]

Eric Christopher <echristo@redhat.com> writes:

> On Thu, 2004-09-09 at 11:07, Michael Snyder wrote:
>> Hi folks,
>> 
>> Looks like your patch submission process is fairly similar to gdb's...
>> 
>> Adding this 'else' to the inner loop in _cpp_clean_line seems pretty 
>> obvious.
>> Since it's on the critical path, it might even yield a trivial performance 
>> win.
>
> As Paul said, there's no performance win here that I can see, but for
> clarity the else should probably be there.

Speaking with my cpplib maintainer hat on, I actually prefer *not* to
have an else there.  It makes me think that maybe there's some way
control can get past the break statement.

zw