C++: enum parsing speedups
Nathan Sidwell
nathan@codesourcery.com
Sat Sep 4 10:22:00 GMT 2004
Zack Weinberg wrote:
> Mark Mitchell <mark@codesourcery.com> writes:
>
>
>>We don't want do add more of those calls if we can help it; those
>>functions are on the fast path, and the c_l_s_s_p function is not free.
>>Just change the error markers in the test case, assuming the messages
>>come out somewhere sensible. We've done that plenty in the past;
>>whether or not an error message shows up on the {enum,class}-specifier,
>>or the curly brace, is not a very big deal.
>
>
> I'm fine with that - in fact I personally think it makes more sense
> for the message to come out on the line with the identifier on it -
> but the point of g++.other/enum2.C is very specifically to enforce
> that the message comes out on the line with the curly brace. I'm
> cc:ing Nathan Sidwell as he added the test. Nathan, do you still have
> an opinion here?
on the identifer is best. I'd guess that previously the error location
was neither the identifier nor curly brace.
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery LLC
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk
More information about the Gcc-patches
mailing list