[toplevel, Cygwin] Don't warn if both newlib and winsup are missing

Kelley Cook kcook@gcc.gnu.org
Tue Oct 12 16:44:00 GMT 2004


In July a patch was added to the Cygwin's toplevel that turns off newlib 
if winsup isn't also present.

In the review, a suggestion was made to warn when this was not the case 
and this was added and eventually committed.

The problem is when both cygwin and newlib are not present like when you 
build binutils or gcc under cygwin you now always get the warning.  
Though harmless, it annoys me.

So this simple patch suppresses that warning if there was no attempt to 
build newlib.

Tested in various combined trees using all four combinations with the 
following results:

a) newlib=no, winsup=no: No warning, neither built
b) newlib=yes, winsup=no: Warning, neither built
c) newlib=no, winsup=yes: No warning, winsup built
d) newlib=yes, winsup=yes: No warning, newlib and winsup built

There is no change in behaviour besides supressing the warning for case a).

OK to install?
Kelley Cook
(BTW no src cvswrite priv)

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: winsup_warning.patch
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20041012/d06982ea/attachment.ksh>


More information about the Gcc-patches mailing list