[patch] tree-phinodes.c: Make make_phi_node static.

Daniel Berlin dberlin@dberlin.org
Sun Nov 7 17:08:00 GMT 2004


On Sun, 7 Nov 2004, Kazu Hirata wrote:

>
> I was actually thinking about addressing this issue.  The main
> difficulty is that people want to copy a chain of PHI nodes while
> doing different things.

Yes.  Our copying/moving of phi nodes is not quite easy to work with right 
now.

For example, there is also no sane way to move phi nodes between blocks 
when you  redirect an edge (see the mess in perfect_nestify that does 
this), and know what the result will be (IE that the phi nodes need to 
simply move  from one block to another).

By sane i mean "doesn't require creating brand new phi nodes and updating 
all the immediate uses of the phi node for a new name".
I specifically want to avoid all the churn involved, otherwise i'd 
just create all new phis with exactly the correct arguments, and replace 
all the immediate uses of the old phi with the new phis.
  :)

--Dan



More information about the Gcc-patches mailing list