RFA: Add dg-require-int-sized-pointers to testsuite

Richard Sandiford rsandifo@redhat.com
Fri Nov 5 09:59:00 GMT 2004


Richard Henderson <rth@redhat.com> writes:
> On Mon, Nov 01, 2004 at 08:03:02PM +0000, Richard Sandiford wrote:
>> 	* lib/target-supports.exp (get_compiler_messages): New procedure,
>> 	extracting and generalizing code from...
>> 	(check_named_sections_available): ...here.
>> 	(check_int_sized_pointers): New procedure.
>> 	* lib/gcc-dg.exp (dg-require-int-sized-pointers): New procedure.
>> 	* g++.dg/parse/cast1.C: Use dg-require-int-sized-pointers.
>> 	* g++.old-deja/g++.mike/p784.C: Likewise.
>
> Ok, I guess.

Thanks.  For the record, I'm holding off this patch in favour of
Janis's more comprehensive one:

    http://gcc.gnu.org/ml/gcc-patches/2004-11/msg00172.html

If that patch is accepted, would it be OK to use:

    { dg-require-effective-target ilp32 }

instead of dg-require-int-sized-pointers?

If not, an alternative would be to add a new dg-require-effective-target
keyword that tests the same thing as dg-require-int-sized-pointers
(ref: http://gcc.gnu.org/ml/gcc-patches/2004-11/msg00215.html).

> Though normally these types of casts are not a feature of the actual
> test case.

True, but since lots of code does seem to cast pointers to or from int,
I guess it's nice to have something for it in the testsuite...

Richard



More information about the Gcc-patches mailing list