[PATCH] Fix bootstrap failure on ppc-darwin
Nathan Sidwell
nathan@codesourcery.com
Tue Nov 2 12:48:00 GMT 2004
Richard Earnshaw wrote:
> On Mon, 2004-11-01 at 05:33, Geoffrey Keating wrote:
>
>>Andrew Pinski <pinskia@physics.uc.edu> writes:
>>>ChangeLog:
>>>
>>> * bitmap.h (bmp_iter_end_p): Take a const pointer instead of a struct.
>>> (EXECUTE_IF_SET_IN_BITMAP): Update call to bmp_iter_end_p.
>>> (EXECUTE_IF_AND_COMPL_IN_BITMAP): Likewise.
>>> (EXECUTE_IF_AND_IN_BITMAP): Likewise.
>
>
> This patch begs the question why we are passing iterators by value at
> all. Looking at the code generated for all of these little structures
> we see huge numbers of structure copies that aren't being eliminated
> even when the iterator functions get inlined.
I have a patch pending which makes the iterators smaller and exclusively
passes the address around.
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery LLC
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk
More information about the Gcc-patches
mailing list