Candidate fix for PR 15007

Geoff Keating geoffk@desire.geoffk.org
Fri May 7 04:09:00 GMT 2004


> From: Zack Weinberg <zack@codesourcery.com>
> Date: Wed, 05 May 2004 15:24:58 -0700

> Geoff Keating <geoffk@desire.geoffk.org> writes:
> 
> > In theory, there is no reason why DECL_ASSEMBLER_NAME should be set
> > before the end of compilation.  You could easily ensure this by
> > changing c_static_assembler_name to do:
> >
> > if (!TREE_PUBLIC (decl) && !DECL_CONTEXT (decl))
> >   abort ();
> 
> I looked into this.  Fixing all these places appears tractable,
> however, it touches a lot of fiddly code that's going to get hit by
> the tree-ssa merge.
> 
> I would therefore like to check in my original patch, which solves the
> PCH bug, and then wait until tree-ssa merges before trying to fix
> IMA.  Is that all right with you?

Sure; perhaps you could work on the IMA fix on the tree-ssa branch
sources so as to be ready to commit it right after the merge (or
earlier if the merge is delayed).

-- 
- Geoffrey Keating <geoffk@geoffk.org>



More information about the Gcc-patches mailing list