PATCH: PR target/15290: __float128 failed to pass to function properly

Zack Weinberg zack@codesourcery.com
Wed May 5 18:39:00 GMT 2004


"H. J. Lu" <hjl@lucon.org> writes:

> The problem

Uh, what problem?  I presume you mean the bug report referenced in the
subject, but it is very helpful when reviewing patches if you
summarize the bug.

...
> -	      REAL_VALUE_TO_TARGET_LONG_DOUBLE (r, l);
> +	      if (mode == TFmode)
> +		REAL_VALUE_TO_TARGET_QUAD_DOUBLE (r, l);
> +	      else
> +		REAL_VALUE_TO_TARGET_LONG_DOUBLE (r, l);

Better just

-      REAL_VALUE_TO_TARGET_LONG_DOUBLE (r, l);       
+      real_to_target (l, &r, mode);

and then you don't need to introduce yet another macro.

zw



More information about the Gcc-patches mailing list