rs6000 -mcpu overrides -msoft-float

Alan Modra amodra@bigpond.net.au
Fri Mar 19 08:14:00 GMT 2004


On Sun, Mar 07, 2004 at 09:48:59PM -0500, David Edelsohn wrote:
> 	* config/rs6000/rs6000.c (rs6000_override_options): Don't override
> 	-msoft-float by -mcpu.  Consolidate similar code for MASK_MULTIPLE
> 	and MASK_STRING.
> 
> Okay for both.  Next patch in this function, I want to see confirmation by
> a VHDL logic verifier. :-)

Thanks.  Committed.  I also committed the fix you okayed on irc a few
days ago for the offset range check in legitimate_offset_address_p.

For the record, I think my rs6000_override_options fix doesn't go far
enough.  Options other than -msoft-float will suffer a similar fate,
eg. -mcpu=620 -mno-powerpc-gfxopt will result in MASK_PPC_GFXOPT being
set.

Perhaps the answer is to use
  set_masks &= ~target_flags_explicit;
instead of
  set_masks &= ~(target_flags_explicit
		 & (MASK_MULTIPLE | MASK_STRING | MASK_SOFT_FLOAT));

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre



More information about the Gcc-patches mailing list