[PING] patch for PR13708 for 3.4 and the mainline

Michael Koch konqueror@gmx.de
Fri Mar 19 08:14:00 GMT 2004


Am Montag, 1. März 2004 03:01 schrieb Andrew Pinski:
> http://gcc.gnu.org/ml/gcc-patches/2004-01/msg03355.html
> Do not use getClass but link to the selected class.

!       String c_encoding = canonicalize (encoding);
!       if (c_encoding.equals("8859_1"))  return new Output_8859_1 ();
!       if (c_encoding.equals("ASCII"))   return new Output_ASCII ();
!       if (c_encoding.equals("EUCJIS"))  return new Output_EUCJIS ();
!       if (c_encoding.equals("JavaSrc")) return new Output_JavaSrc ();
!       if (c_encoding.equals("SJIS"))    return new Output_SJIS ();
!       if (c_encoding.equals("UTF8"))    return new Output_UTF8 ();
!       if (c_encoding.equals("iconv"))   return new Output_iconv 
(c_encoding);
!       return new Output_iconv (encoding);

I wonder if this is correct or sufficient. Shouldnt "ASCII" be called 
"US-ASCII", "8859_1" should probably be "ISO-8859-1", "UTF8" should be 
"UTF-8". "UTF-16", "UTF-16BE" and "UTF-16LE" is totally missing.
I think we should at least put all the default JVM encodings here.


Michael



More information about the Gcc-patches mailing list