[PATCH]: GVN-PRE

[Mark Mitchell]

Daniel Berlin wrote:

> 
> On Jun 15, 2004, at 11:15 AM, Mark Mitchell wrote:
> 
>>
>>>    For debugging reasons, the value handle is internally more than
>>>    just a number, it is a VAR_DECL named "value.x", where x is a
>>>    unique number for each value number in use.  This allows
>>>    expressions with SSA_NAMES replaced by value handles to still be
>>>    pretty printed in a sane way.  They simply print as "value.3 *
>>>    value.5", etc.
>>
>>
>> This is a bad idea in the longer term.  VAR_DECLs are big; we're 
>> wasting a lot of memory here.
> 
> Yes, i'm aware.  It was still using a lot less memory than SSAPRE used 
> to (since it used to possibly create multiple tree nodes per variable), 
> and it was a first step.

Yes, and the numbers you posted certainly were convincing evidence that 
the new version is a big improvement.  I was just highlighting a further 
improvement that could be made.

> I'll update this comment, and verify the others are still sane/not missing.
> I had gone through most of them before it was committed, but it's 
> obvious i must have missed a few.

Thanks!

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com