[trunk + 3.4-branch RFA] don't use empic relocs for mips-linux eh

Richard Sandiford rsandifo@redhat.com
Mon Jun 14 13:24:00 GMT 2004


cgd@broadcom.com writes:
> I'd like this approved for the branch as well, so 3.4.1 will work
> nicely w/ the next major binutils release.

Agreed that using embedded pic relocations for linux is a bug.
It's almost certainly a regression from some earlier version of gcc,
so if you can give a specific version number, I think the patch should
be OK for 3.4.x.

> +/* If possible, we should attempt to use GP-relative relocs for this
> +   (see http://sources.redhat.com/ml/binutils/2004-05/msg00227.html).
> +   However, until that is implement, this just uses standard, absolute
                             ^^^^^^^^^
typo

> +   references.  */
> +#define ASM_PREFERRED_EH_DATA_FORMAT(CODE, GLOBAL)	DW_EH_PE_absptr

This is the same as the definition in defaults.h.  Do we really need it?
If not, and given that the comment references a URL anyway, I think it
would be better to just remove both the linux.h and linux64.h definitions.
Anyone who wonders why can go to Google.

A patch to remove both definitions is preapproved if it works.

Richard



More information about the Gcc-patches mailing list