Remove NOTE_INSN_PREDICTION

Steven Bosscher stevenb@suse.de
Wed Jul 21 17:43:00 GMT 2004


Hi,

NOTE_INSN_PREDICTION was only still used for return predictions,
which are broken since the patch to unify return statements for
lower GIMPLE.  So we spend a lot of time (computing DOM and PDOM)
in predict.c only to predict a single return with a very poor and
broken prediction.

With this patch, we no longer predict returns like this.  I will
reimplement this in the tree branch prediction code instead.

Bootstrapped on i686-suse-linux-gnu, testing ongoing.  OK when it
passes?

Gr.
Steven


        * rtl.h (insn_note): Remove NOTE_INSN_PREDICTION.
        * rtl.c (note_insn_name): Likewise.
        * print-rtl.c (print_rtx): Don't print it.
        * cfgrtl.h (can_delete_note_p): Don't handle it.
        (rtl_delete_block): Likewise.
        * passes.c (rest_of_handle_guess_branch_prob): Remove.
        (rest_of_compilation): Don't call it.
        * predict.c (process_note_predictions, process_note_prediction,
        note_prediction_to_br_prob): Remove.
        * basic-block.c (note_prediction_to_br_prob): Remove prototype.
        * stmt.c (return_prediction): Remove.
        (expand_value_return): Don't call it.  Don't add prediction
        notes for return statements.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: application/octet-stream
Size: 13930 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20040721/9bf4e388/attachment.obj>


More information about the Gcc-patches mailing list