re-establish NetWare as a supported (cross-only) target

Jan Beulich JBeulich@novell.com
Thu Jul 8 09:00:00 GMT 2004


>Lets look at this part again:
>+  newsym = xmalloc (1 + strlen (asmname) + 1 + 10 + 1);
>+  sprintf (newsym, "%c%s@%d", FASTCALL_PREFIX, asmname,
>  total/BITS_PER_UNIT);
>+  return IDENTIFIER_POINTER (get_identifier (newsym));
>
>
>It is too local to the function as we know that get_identifier will
>always copy the string to a new char pointer it does not matter.

OK, if get_identifier() always makes a copy... Again, I just modfied
pre-exisiting code.

>> >Because the C standard says a stand alone (free standing I think
is
>> >the correct term here) compiler must provide them.
>
>You have not answered this part yet, why are trying to violate the
>standard here.

As I said, I have only limited influence on what the NetWare libc
headers look like. There are far more severe standard violations in
there that I can't get them to correct...

>> >stddef.h because we have our own defintion of offsetof which
depends
>> on the
>> >compiler version you are using, pre 3.4, it is the normal offsetof
>> macro that
>> >everyone defines it as.  3.4.x it is special only for C++ and then
for
>> 3.5.0 and
>> >above we have our own defintion so that the constants expressions
can
>> be constant
>> >expressions.
>> 
>> I already adjusted the NetWare stddef.h for this.
>
>For all three defintions?

Yes.



More information about the Gcc-patches mailing list