[patch] Lno branch merge -- scalar evolutions analyzer

Zack Weinberg zack@codesourcery.com
Tue Jul 6 16:55:00 GMT 2004


Sebastian Pop <sebastian.pop@cri.ensmp.fr> writes:

> On Mon, Jul 05, 2004 at 08:12:07PM -0700, Mark Mitchell wrote:
>> 
>> Do you think that these accessor functions are worth it?  It seems like 
>> we already have a ton of code that just does "e->src", etc.  It seems to 
>> me like we should just use the "->" form, unless we want to go through 
>> and change all the existing code.  I don't think this is a big deal one 
>> way or the other, though.
>> 
>
> IMO it is a better practice to access the fields of a struct via
> functions or macros.

I disagree vehemently.  When the function or macro does nothing other
than the pointer dereference, it is obfuscation.

(You're not going to get consensus on this.)

zw



More information about the Gcc-patches mailing list