[tree-ssa] Cleanup and enhance dominator infrastructure

law@redhat.com law@redhat.com
Tue Jan 6 17:39:00 GMT 2004


In message <20040106103113.GA27161@atrey.karlin.mff.cuni.cz>, Zdenek Dvorak wri
tes:
 >> If it's as slow as Zdenek claims, then we might as well just kill DEBUG_ET.
 >
 >the code was really useful to debug the thing.  I would like to keep it
 >there for the case it sometimes in the future turns out there is a bug
 >somewhere in the code.
OK.


 >>  >> ! static int len;
 >>  >> ! static void *datas[100000];
 >>  >> ! static int depths[100000];
 >>  >>
 >>  >Please #define these values and add guards in record_path_before_1.
 >> Err, really?  So we're just going to blindly allocate nearly a megabyte
 >> of static data on a 32bit machine?  That's lame, really lame.  We're better
 >> off getting that much data from the heap via malloc/free.
 >
 >These arrays are there only when DEBUG_ET is enabled.
Ah.  OK.  I don't care about them in that case :-)

I think Diego approved the changes for the branch and Roger approved 
a port of them for the mainline (which helps keep divergence to a
minimum :-)


Jeff






More information about the Gcc-patches mailing list