[tree-ssa] Enable warnings for libbanshee

Andreas Jaeger aj@suse.de
Sun Feb 29 14:13:00 GMT 2004


Here's a patch to enable warnings in libbanshee (similar to how we do
it in libiberty).

This gives rather a lot of warnings.  So the question is again, will
libbanshee merged to mainline with tree-ssa?  In that case this patch
should be applied and the warnings get fixed...

Ok to commit?  Tested on amd64-linux,

Andreas

2004-02-29  Andreas Jaeger  <aj@suse.de>

	* configure.in: Set ac_libbanshee_warn_cflags for GCC.
	* configure: Regenerated.

	* libcompat/Makefile.am (AM_CFLAGS): Add
	ac_libbanshee_warn_cflags.
	* engine/Makefile.am (AM_CFLAGS): Likewise.
	* points-to/Makefile.am (AM_CFLAGS): Likewise.
	* libcompat/Makefile.in: Regenerated.
	* engine/Makefile.in: Regenerated.
	* points-to/Makefile.in: Regenerated.

	* libcompat/radix-tree.c: Include <stdlib.h> for calloc.
============================================================
Index: configure.in
--- configure.in	3 Jul 2003 05:23:56 -0000	1.1.2.4
+++ configure.in	29 Feb 2004 09:23:37 -0000
@@ -13,6 +13,13 @@ AC_PROG_RANLIB
 # FIXME: Replace `main' with a function in `-lm':
 #AC_CHECK_LIB([m], [main])
 
+GCC_NO_EXECUTABLES
+
+if test x$GCC = xyes; then
+  ac_libiberty_warn_cflags='-W -Wall -Wtraditional -pedantic'
+fi
+AC_SUBST(ac_libiberty_warn_cflags)
+
 AM_MAINTAINER_MODE
 # Checks for header files.
 AC_HEADER_STDC
============================================================
Index: configure
--- configure	4 Feb 2004 15:25:03 -0000	1.1.2.8
+++ configure	29 Feb 2004 09:23:40 -0000
@@ -309,7 +309,7 @@ ac_includes_default="\
 # include <unistd.h>
 #endif"
 
-ac_subst_vars='SHELL PATH_SEPARATOR PACKAGE_NAME PACKAGE_TARNAME PACKAGE_VERSION PACKAGE_STRING PACKAGE_BUGREPORT exec_prefix prefix program_transform_name bindir sbindir libexecdir datadir sysconfdir sharedstatedir localstatedir libdir includedir oldincludedir infodir mandir build_alias host_alias target_alias DEFS ECHO_C ECHO_N ECHO_T LIBS INSTALL_PROGRAM INSTALL_SCRIPT INSTALL_DATA CYGPATH_W PACKAGE VERSION ACLOCAL AUTOCONF AUTOMAKE AUTOHEADER MAKEINFO AMTAR install_sh STRIP ac_ct_STRIP INSTALL_STRIP_PROGRAM AWK SET_MAKE am__leading_dot CC CFLAGS LDFLAGS CPPFLAGS ac_ct_CC EXEEXT OBJEXT DEPDIR am__include am__quote AMDEP_TRUE AMDEP_FALSE AMDEPBACKSLASH CCDEPMODE am__fastdepCC_TRUE am__fastdepCC_FALSE RANLIB ac_ct_RANLIB MAINTAINER_MODE_TRUE MAINTAINER_MODE_FALSE MAINT CPP EGREP LIBOBJS LTLIBOBJS'
+ac_subst_vars='SHELL PATH_SEPARATOR PACKAGE_NAME PACKAGE_TARNAME PACKAGE_VERSION PACKAGE_STRING PACKAGE_BUGREPORT exec_prefix prefix program_transform_name bindir sbindir libexecdir datadir sysconfdir sharedstatedir localstatedir libdir includedir oldincludedir infodir mandir build_alias host_alias target_alias DEFS ECHO_C ECHO_N ECHO_T LIBS INSTALL_PROGRAM INSTALL_SCRIPT INSTALL_DATA CYGPATH_W PACKAGE VERSION ACLOCAL AUTOCONF AUTOMAKE AUTOHEADER MAKEINFO AMTAR install_sh STRIP ac_ct_STRIP INSTALL_STRIP_PROGRAM AWK SET_MAKE am__leading_dot CC CFLAGS LDFLAGS CPPFLAGS ac_ct_CC EXEEXT OBJEXT DEPDIR am__include am__quote AMDEP_TRUE AMDEP_FALSE AMDEPBACKSLASH CCDEPMODE am__fastdepCC_TRUE am__fastdepCC_FALSE RANLIB ac_ct_RANLIB ac_libiberty_warn_cflags MAINTAINER_MODE_TRUE MAINTAINER_MODE_FALSE MAINT CPP EGREP LIBOBJS LTLIBOBJS'
 ac_subst_files=''
 
 # Initialize some variables set by options.
@@ -2879,6 +2879,13 @@ fi
 # FIXME: Replace `main' with a function in `-lm':
 #AC_CHECK_LIB([m], [main])
 
+GCC_NO_EXECUTABLES
+
+if test x$GCC = xyes; then
+  ac_libiberty_warn_cflags='-W -Wall -Wtraditional -pedantic'
+fi
+
+
 echo "$as_me:$LINENO: checking whether to enable maintainer-specific portions of Makefiles" >&5
 echo $ECHO_N "checking whether to enable maintainer-specific portions of Makefiles... $ECHO_C" >&6
     # Check whether --enable-maintainer-mode or --disable-maintainer-mode was given.
@@ -5322,6 +5329,7 @@ s,@am__fastdepCC_TRUE@,$am__fastdepCC_TR
 s,@am__fastdepCC_FALSE@,$am__fastdepCC_FALSE,;t t
 s,@RANLIB@,$RANLIB,;t t
 s,@ac_ct_RANLIB@,$ac_ct_RANLIB,;t t
+s,@ac_libiberty_warn_cflags@,$ac_libiberty_warn_cflags,;t t
 s,@MAINTAINER_MODE_TRUE@,$MAINTAINER_MODE_TRUE,;t t
 s,@MAINTAINER_MODE_FALSE@,$MAINTAINER_MODE_FALSE,;t t
 s,@MAINT@,$MAINT,;t t
============================================================
Index: engine/Makefile.am
--- engine/Makefile.am	4 Feb 2004 15:25:03 -0000	1.1.2.3
+++ engine/Makefile.am	29 Feb 2004 09:23:40 -0000
@@ -1,4 +1,4 @@
-AM_CFLAGS = -I$(srcdir)/../libcompat -I$(srcdir)/../include -I. -Ddeletes= -Dtraditional= -Dsameregion= -Dparentptr= 
+AM_CFLAGS = -I$(srcdir)/../libcompat -I$(srcdir)/../include -I. -Ddeletes= -Dtraditional= -Dsameregion= -Dparentptr= @ac_libbanshee_warn_cflags@
 noinst_LIBRARIES = libbansheeengine.a
 libbansheeengine_a_SOURCES =  array.c bounds.c hash.c hashset.c list.c stamp.c \
 ufind.c util.c setif-sort.c termhash.c setif-var.c flow-var.c flowrow-sort.c \
============================================================
Index: engine/Makefile.in
--- engine/Makefile.in	4 Feb 2004 15:25:03 -0000	1.1.2.8
+++ engine/Makefile.in	29 Feb 2004 09:23:40 -0000
@@ -84,6 +84,7 @@ VERSION = @VERSION@
 ac_ct_CC = @ac_ct_CC@
 ac_ct_RANLIB = @ac_ct_RANLIB@
 ac_ct_STRIP = @ac_ct_STRIP@
+ac_libiberty_warn_cflags = @ac_libiberty_warn_cflags@
 am__fastdepCC_FALSE = @am__fastdepCC_FALSE@
 am__fastdepCC_TRUE = @am__fastdepCC_TRUE@
 am__include = @am__include@
@@ -108,7 +109,7 @@ sbindir = @sbindir@
 sharedstatedir = @sharedstatedir@
 sysconfdir = @sysconfdir@
 target_alias = @target_alias@
-AM_CFLAGS = -I$(srcdir)/../libcompat -I$(srcdir)/../include -I. -Ddeletes= -Dtraditional= -Dsameregion= -Dparentptr= 
+AM_CFLAGS = -I$(srcdir)/../libcompat -I$(srcdir)/../include -I. -Ddeletes= -Dtraditional= -Dsameregion= -Dparentptr= @ac_libbanshee_warn_cflags@
 noinst_LIBRARIES = libbansheeengine.a
 libbansheeengine_a_SOURCES = array.c bounds.c hash.c hashset.c list.c stamp.c \
 ufind.c util.c setif-sort.c termhash.c setif-var.c flow-var.c flowrow-sort.c \
============================================================
Index: libcompat/Makefile.am
--- libcompat/Makefile.am	4 Feb 2004 15:25:04 -0000	1.1.2.4
+++ libcompat/Makefile.am	29 Feb 2004 09:23:40 -0000
@@ -1,4 +1,4 @@
-AM_CFLAGS = -I$(srcdir)/../engine -I$(srcdir)/../include -I. -Ddeletes= -Dtraditional= -Dsameregion= -Dparentptr= 
+AM_CFLAGS = -I$(srcdir)/../engine -I$(srcdir)/../include -I. -Ddeletes= -Dtraditional= -Dsameregion= -Dparentptr= @ac_libbanshee_warn_cflags@
 noinst_LIBRARIES = libbansheecompat.a
 libbansheecompat_a_SOURCES = regions.c radix-tree.c
 
============================================================
Index: libcompat/Makefile.in
--- libcompat/Makefile.in	4 Feb 2004 15:25:04 -0000	1.1.2.9
+++ libcompat/Makefile.in	29 Feb 2004 09:23:40 -0000
@@ -84,6 +84,7 @@ VERSION = @VERSION@
 ac_ct_CC = @ac_ct_CC@
 ac_ct_RANLIB = @ac_ct_RANLIB@
 ac_ct_STRIP = @ac_ct_STRIP@
+ac_libiberty_warn_cflags = @ac_libiberty_warn_cflags@
 am__fastdepCC_FALSE = @am__fastdepCC_FALSE@
 am__fastdepCC_TRUE = @am__fastdepCC_TRUE@
 am__include = @am__include@
@@ -108,7 +109,7 @@ sbindir = @sbindir@
 sharedstatedir = @sharedstatedir@
 sysconfdir = @sysconfdir@
 target_alias = @target_alias@
-AM_CFLAGS = -I$(srcdir)/../engine -I$(srcdir)/../include -I. -Ddeletes= -Dtraditional= -Dsameregion= -Dparentptr= 
+AM_CFLAGS = -I$(srcdir)/../engine -I$(srcdir)/../include -I. -Ddeletes= -Dtraditional= -Dsameregion= -Dparentptr= @ac_libbanshee_warn_cflags@
 noinst_LIBRARIES = libbansheecompat.a
 libbansheecompat_a_SOURCES = regions.c radix-tree.c
 subdir = libcompat
============================================================
Index: points-to/Makefile.am
--- points-to/Makefile.am	4 Feb 2004 15:25:04 -0000	1.1.2.3
+++ points-to/Makefile.am	29 Feb 2004 09:23:40 -0000
@@ -1,4 +1,4 @@
-AM_CFLAGS = -I$(srcdir)/../libcompat -I$(srcdir)/../include -I$(srcdir)/.. -Ddeletes= -Dtraditional= -Dsameregion= -Dparentptr= 
+AM_CFLAGS = -I$(srcdir)/../libcompat -I$(srcdir)/../include -I$(srcdir)/.. -Ddeletes= -Dtraditional= -Dsameregion= -Dparentptr= @ac_libbanshee_warn_cflags@
 noinst_LIBRARIES = libandersen.a
 libandersen_a_SOURCES = andersen_terms.c
 
============================================================
Index: points-to/Makefile.in
--- points-to/Makefile.in	4 Feb 2004 15:25:04 -0000	1.1.2.8
+++ points-to/Makefile.in	29 Feb 2004 09:23:40 -0000
@@ -84,6 +84,7 @@ VERSION = @VERSION@
 ac_ct_CC = @ac_ct_CC@
 ac_ct_RANLIB = @ac_ct_RANLIB@
 ac_ct_STRIP = @ac_ct_STRIP@
+ac_libiberty_warn_cflags = @ac_libiberty_warn_cflags@
 am__fastdepCC_FALSE = @am__fastdepCC_FALSE@
 am__fastdepCC_TRUE = @am__fastdepCC_TRUE@
 am__include = @am__include@
@@ -108,7 +109,7 @@ sbindir = @sbindir@
 sharedstatedir = @sharedstatedir@
 sysconfdir = @sysconfdir@
 target_alias = @target_alias@
-AM_CFLAGS = -I$(srcdir)/../libcompat -I$(srcdir)/../include -I$(srcdir)/.. -Ddeletes= -Dtraditional= -Dsameregion= -Dparentptr= 
+AM_CFLAGS = -I$(srcdir)/../libcompat -I$(srcdir)/../include -I$(srcdir)/.. -Ddeletes= -Dtraditional= -Dsameregion= -Dparentptr= @ac_libbanshee_warn_cflags@
 noinst_LIBRARIES = libandersen.a
 libandersen_a_SOURCES = andersen_terms.c
 subdir = points-to

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20040229/972dbb1e/attachment.sig>


More information about the Gcc-patches mailing list