Patch for stl_vector.h and vector.tcc.

Dhruv Matani dhruvbird@gmx.net
Sat Feb 21 13:45:00 GMT 2004


On Thu, 2004-02-12 at 07:39, Benjamin Kosnik wrote:
> >Also, I have attached a test case which seg_faults in the older
> >(unpatched) vector implementation. So, a way of testing whether the
> >patch worked!
> 
> Nice job.

Thanks ;-)


> A couple of things
> 
> 1) can you audit the other containers that changed, that may also have
> this problem? If they exhibit it, can you also do separate testcases for them?

Sure thing. I have attached a patch for deque. The test case attached
will result in mutual infinite recursion with the current(older) deque
implementation, and will work with the patched one (way to check if the
patch worked!)


> 2) cvs diff -N for new files.

Ok.


> 3) please pay attention to the coding conventions in C++STYLE, and the
> code surrounding your patch.

Ok. Done that this time around!




BTW, Benjamin, I have sent the copyrights by snail mail today. They
should reach in about 8~9 days. At least that's what I was told!




-- 
	-Dhruv Matani.
http://www.geocities.com/dhruvbird/


-------------- next part --------------
A non-text attachment was scrubbed...
Name: alloc_opt.cpp
Type: text/x-c++
Size: 2365 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20040221/9c0ffb07/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.deque.120202004.dhruv
Type: text/x-patch
Size: 57631 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20040221/9c0ffb07/attachment-0001.bin>


More information about the Gcc-patches mailing list