My "Small" AltiVec Patch - TAKE 4

[Ziemowit Laski]

On 8 Feb, 2004, at 12.24, Andrew Pinski wrote:

>
> On Feb 8, 2004, at 12:12, Ziemowit Laski wrote:
>> Aside from that, I can now say I've done bootstraps with and without
>> the patch, and there are absolutely no regressions.  OK to install?
>
> I would really like to see this patch split up into at least three 
> pieces
> so it is easier to reviewed by someone and find out where regressions 
> are
> caused.

What regressions?

>
>>
>> [gcc/ChangeLog]
>> 2004-02-08  Ziemowit Laski  <zlaski@apple.com>
>>
> These can go into their own patch first, I do not think Aldy can 
> approve
> these also:
>>         * c-common.c (vector_size_helper): Make externally visible.
>>         * c-common.h (vector_size_helper): Add prototype.
>>         * tree.c (make_vector): Make externally visible.
>>         * tree.h (make_vector): Add prototype.
>
>
> These can also go into their own patch:
>>         * config/darwin.h (TARGET_OPTION_TRANSLATE_TABLE) Refer to
>>         SUBTARGET_OPTION_TRANSLATE_TABLE for architecture-specific 
>> options.
>>         * config/i386/darwin.h (SUBTARGET_OPTION_TRANSLATE_TABLE). 
>> Define it.

> This can go into a different patch:
>>         * config/rs6000/darwin.h (SUBTARGET_OPTION_TRANSLATE_TABLE): 
>> New macro
>>         defining Darwin/PowerPC-specific '-f[no-]altivec' and
>>         '-W[no-]altivec-long-deprecated' switches.
>

No they can't.  See my response to Aldy.

>
> This patch is already done:
>>         wrap C++-specific portion of header with 'extern "C

Yes, this is a ChangeLog-only bug. :-)
>
> A patch with __pixel done, one for __vector, and one __bool would be 
> better.

I don't follow this planktonization argument at all.  Why would it be 
better
to separate things that naturally belong together (and, in most cases, 
interdependent)?

--Zem

--------------------------------------------------------------
Ziemowit Laski                 1 Infinite Loop, MS 301-2K
Mac OS X Compiler Group        Cupertino, CA USA  95014-2083
Apple Computer, Inc.           +1.408.974.6229  Fax .5477