[PATCH] fix exec-charset

Joseph S. Myers jsm@polyomino.org.uk
Fri Feb 13 01:53:00 GMT 2004


On Thu, 12 Feb 2004, Eric Christopher wrote:

>  /* Full-blown asm statement with inputs, outputs, clobbers, and
>     volatile tag allowed.  */
>  asm_stmt:
> -	ASM_KEYWORD maybe_volatile '(' asm_argument ')' ';'
> +	asm_keyword maybe_volatile '(' asm_argument ')'
> +	   start_string_translation ';'

I think you need to be more fine-grained here; couldn't an input operand
contain arbitrary expressions including string literals that should be in
the execution charset?  I.e., asm_operand should have translation off for
the string but on for the expression.

-- 
Joseph S. Myers
jsm@polyomino.org.uk



More information about the Gcc-patches mailing list