[patch] Lno branch merge part 12 -- induction variable optimizations

Michael Matz matz@suse.de
Mon Aug 30 12:40:00 GMT 2004


Hi,

On Sun, 29 Aug 2004, Zdenek Dvorak wrote:

> > >>than make remove_statement() also externally visible :-).
> > >
> > >Why?
> > 
> > see above.
> 
> what exactly you mean? I see nothing above which would justify
> exporting remove_statement.

I think Devang meant his answer to your first question to explain, where 
he wrote:

"I use bitmap to mark statements that are candidate for removal. And then 
do one walk of statements to remove marked statements."

I assume that for this bulk removal he needed the function exported.

> > >>No, comments explaining how the cost is calculated.
> > >
> > >??? What would you like to write there?
> > 
> > You are intimately familiar with this code so everything is obvious for 
> > you.
> 
> No I am not. I wrote the multiply_by_cost function 6 months ago, so I no
> longer recalled anything about its inner workings when I looked whether
> I can do anything with your request to add a comment to it.  It is just
> that trivial that I do not think a comment would make it any cleaner

Well, perhaps just adding something like "by expanding the sequence to 
RTL, estimate its cost and cache the result" would do already.


Ciao,
Michael.



More information about the Gcc-patches mailing list