[PATCH] add gcc_assert

Joseph S. Myers jsm@polyomino.org.uk
Fri Aug 27 16:49:00 GMT 2004


On Fri, 27 Aug 2004, Giovanni Bajo wrote:

> Nice. Can we have some pre-approval for patches which change calls to
> abort()/my_friendly_assert() into the new gcc_assert()/gcc_unreadable()?

Just remember such changes are *not* purely mechanical, as you need to 
convince yourself in each case that the expression being asserted has no 
side effects.  So it would be safest to submit those cases where at first 
glance there might be side effects (e.g. cases where the asserted 
expression involves a function call) separately from the purely routine 
cases where there clearly aren't side effects.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)



More information about the Gcc-patches mailing list