[C++ PATCH] Clean up primary base determination

Mark Mitchell mark@codesourcery.com
Wed Aug 25 17:31:00 GMT 2004


Nathan Sidwell wrote:

> The current algorithm for determining the primary base looks like
> 1 see if we have a direct primary
> 2a if not, mark where the indirect primaries are
> 2b         look for a nearly empty base which is not already a primary
> 2c       if that fails, steal the first nearly empty base
> 3 finally mark all the primaries of our direct and indirect bases
>   (which essentially repeats step 2a).
>
> The new algorithm does step 3 first, then step 1 then step 2b, and 2c
> If 2c happens, then we do the right fixups on the base whos primary was
> stolen.
>
> booted & tested on i686-pc-linux-gnu, ok?

Yes.

I looked to see if I could find any mistakes, given how complex this bit 
of the front end is, but I couldn't. 

Would you be so kind as to run our ABI testsuite to check your change as 
well?

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com



More information about the Gcc-patches mailing list