C++ patch: bug 17120

[Joseph S. Myers]

On Fri, 20 Aug 2004, Mark Mitchell wrote:

> Joseph S. Myers wrote:
> 
> > This patch fixes bug 17120, inappropriate -Wparentheses warnings for
> > non-plain assignments in the presence of templates;
> > build_x_modify_expr set TREE_NO_WARNING for them but this then got
> > overridden.
> > 
> > Bootstrapped with no regressions on i686-pc-linux-gnu.  OK to commit?
> >  
> With a comment explaining why the straight copy didn't work, yes.

I've put in the following comment.

        /* TREE_NO_WARNING must be set if either the expression was
           parenthesized or it uses an operator such as >>= rather
           than plain assignment.  In the former case, it was already
           set and must be copied.  In the latter case,
           build_x_modify_expr sets it and it must not be reset
           here.  */

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)