PATCH: ARM BPABI library routines

Richard Henderson rth@redhat.com
Wed Aug 11 05:13:00 GMT 2004


On Tue, Aug 10, 2004 at 07:57:19PM -0700, Mark Mitchell wrote:
> *************** init_optabs (void)
>     /* Initialize the optabs with the names of the library functions.  */
> !   if (TARGET_LIBGCC_LIBFUNCS)
> !     {
> !       init_integral_libfuncs (add_optab, "add", '3');

This I think is both broken and unnecessary.

Broken because you're not providing replacements for

> !       init_integral_libfuncs (addv_optab, "addv", '3');
...
> !       init_integral_libfuncs (clz_optab, "clz", '2');
> !       init_integral_libfuncs (ctz_optab, "ctz", '2');
> !       init_integral_libfuncs (popcount_optab, "popcount", '2');
> !       init_integral_libfuncs (parity_optab, "parity", '2');

to name a few.  Unnecessary because 

> + arm_init_libfuncs (void)

This will simply override all of the entry points that have
ABI specified names.  It's what every other target does when
they have to change the names around.


r~



More information about the Gcc-patches mailing list