Unify gcse and cse exp{r,}_equiv_p functions

Steven Bosscher stevenb@suse.de
Sat Aug 7 10:39:00 GMT 2004


On Saturday 07 August 2004 10:23, Paolo Bonzini wrote:
> > I hate hooks.  I don't see why this would be any better.
>
> A matter of taste, I do like hooks :-) more than a parameter named
> FOR_GCSE.
>
> On a pro side, there would be no need to pass extra parameters around,
> so the cse.c part of the patch would be smaller.  On a con side, one
> should check where expr?_equiv_p are in the profiles.

Probably pretty high up there.

If the extra argument really bothers you, we could also just unify
all the validate, equal_values, and for_gcse arguments and turn them
into flags.

Gr.
Steven





More information about the Gcc-patches mailing list