[PATCH - SH] trap_exit and sp_switch with interrupt_handler attribute

[Asgari J. Jinia]

Hi,

> I would welcome a cleanup in this area, however, you have predicate
> functions with side effects, including producing garbage.

Yes that is right but how can I do away with garbage?

> Is there any good reason not get get rid of the variables 
> trap_exit and
> sp_switch altogether?

I have kept them to hold values of trap_exit and sp_switch attributes and use them outside the function. Also sp_switch is used to get symbol reference in sp_switch_1 insn.

> 
> A patch for gcc 3.5 would have to be tested in 3.5 before it 
> could be applied.
Ok I would regression test on gcc 3.5.
> 
> > +      if (sh_cfun_trap_exit_p())
>
> The GNU coding standard requires a blank between the function name and
> the opening paranthesis.
> 
Thanks for such a close observation. This should not have happened. I will add it.

Regards,
Asgari Jinia
KPIT Cummins InfoSystems Ltd.
Pune, India

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Free download of GNU based tool-chains for Renesas' SH and H8 Series.
The following site also offers free technical support to its users. 
Visit http://www.kpitgnutools.com for details. 
Latest versions of KPIT GNU tools are released on June 1, 2004.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~