[patch] libffi/: check mmap() availability explicitly

Tom Tromey tromey@redhat.com
Mon Aug 2 15:46:00 GMT 2004


>>>>> "Maciej" == Maciej W Rozycki <macro@linux-mips.org> writes:

Maciej> 2004-07-30  Maciej W. Rozycki  <macro@linux-mips.org>
Maciej> * acinclude.m4 (AC_FUNC_MMAP_BLACKLIST): Check for <sys/mman.h>
Maciej> and mmap() explicitly instead of relying on preset autoconf cache
Maciej> variables.
Maciej> * aclocal.m4: Regenerate.
Maciej> * configure: Regenerate.

It looks like the intent here was for the explicit checks in
configure.ac to set these variables:

    AC_CHECK_HEADERS(sys/mman.h)
    AC_CHECK_FUNCS(mmap)
    AC_FUNC_MMAP_BLACKLIST

... but IMO relying on autoconf cache variable names is not a very
good practice.  I agree we ought to move these calls into
AC_FUNC_MMAP_BLACKLIST.  Can you re-test with the checks removed from
configure.ac?  If that works for you I will check it in.

Tom



More information about the Gcc-patches mailing list