configury patch: --with-as/--with-ld

Ben Elliston bje@au1.ibm.com
Wed Apr 28 01:21:00 GMT 2004


A sample of two users indicates that often they run into trouble when,
for one reason or another, an incorrect path to the assembler or
linker is provided to --with-as/--with-ld.  A warning isn't really
helpful.  The configure script should produce a hard error.  Okay for
mainline?

Ben


2004-04-28  Ben Elliston  <bje@au.ibm.com>

	* configure.ac (--with-as): Abort if user-supplied assembler
	cannot be executed.
	(--with-ld): Likewise for the linker.
	* configure: Regenerate.

Index: configure.ac
===================================================================
RCS file: /cvs/gcc/gcc/gcc/configure.ac,v
retrieving revision 2.32
diff -u -p -r2.32 configure.ac
--- configure.ac        17 Apr 2004 06:06:52 -0000      2.32
+++ configure.ac        28 Apr 2004 00:48:44 -0000
@@ -192,7 +192,7 @@ AC_ARG_WITH(ld,
 DEFAULT_LINKER="$with_ld")
 if test x"${DEFAULT_LINKER+set}" = x"set"; then
   if test ! -x "$DEFAULT_LINKER"; then
-    AC_MSG_WARN([cannot execute: $DEFAULT_LINKER: check --with-ld or env. var. DEFAULT_LINKER])
+    AC_MSG_ERROR([cannot execute: $DEFAULT_LINKER: check --with-ld or env. var. DEFAULT_LINKER])
   elif $DEFAULT_LINKER -v < /dev/null 2>&1 | grep GNU > /dev/null; then
     gnu_ld_flag=yes
   fi
@@ -226,7 +226,7 @@ AC_ARG_WITH(as,
 DEFAULT_ASSEMBLER="$with_as")
 if test x"${DEFAULT_ASSEMBLER+set}" = x"set"; then
   if test ! -x "$DEFAULT_ASSEMBLER"; then
-    AC_MSG_WARN([cannot execute: $DEFAULT_ASSEMBLER: check --with-as or env. var. DEFAULT_ASSEMBLER])
+    AC_MSG_ERROR([cannot execute: $DEFAULT_ASSEMBLER: check --with-as or env. var. DEFAULT_ASSEMBLER])
   elif $DEFAULT_ASSEMBLER -v < /dev/null 2>&1 | grep GNU > /dev/null; then
     gas_flag=yes
   fi



More information about the Gcc-patches mailing list