[patch, Ada] GNAT for Mac OS X (Darwin) Tasking Support
Arnaud Charlet
charlet@ACT-Europe.FR
Fri Apr 23 06:39:00 GMT 2004
> * Makefile.in: Added target pairs for powerpc-*-darwin* tasking
> support.
You're missing a proper version of system, which will undoubtely cause subtle
troubles.
> * a-intnam-darwin.ads, s-osinte-darwin.ads,
> s-osinte-darwin.adb:
> New files.
>
> The names of the new files have been recommended by ACT.
Actually I recommended a-intnam-osx.ads
Is darwin a stable name ? Is it the preferred name ? If so, the proposed
naming is fine with me.
There are problems with your files: you have extra $Revision lines
The copyright is missing 2004
The comments are wrong (mentioning e.g. FSU threads)
Style issues: the preferred style is
type struct_sigaction is record
...
end record
rather than
type struct_sigaction is
record
...
end record;
Arno
More information about the Gcc-patches
mailing list