ping patches

Per Bothner per@bothner.com
Wed Apr 21 19:01:00 GMT 2004


Andrew Pinski wrote:

> Nobody has reviewed this patch yet:
> <http://gcc.gnu.org/ml/java-patches/2004-q1/msg00912.html>
> [PATCH] speedup the java front-end a little

The basic idea is fine.

To avoid an extra test, it looks like you allow ".class"
but not ".java".  This probably doesn't matter, but the
code is a little hard to read.

Why not keep it simple:

return (len > 5 && strcmp (base + len - 5, ".java"))
     || (len > 6 && strcmp (base + len - 6, ".class"));
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/



More information about the Gcc-patches mailing list