Should ADJUST_FIELD_ALIGN honor __attribute__((packed))?

Mark Mitchell mark@codesourcery.com
Mon Apr 19 21:35:00 GMT 2004


Daniel Jacobowitz wrote:

>Committed to HEAD.  Mark, how do you feel about this patch for 3.4.1?
>It is an ABI change, but only for architectures where
>ADJUST_FIELD_ALIGN can increase the alignment of a field, and only for
>packed structures.  I only know of powerpc/altivec and arm/iwmmxt being
>affected.  For iwmmxt this fixes the alignment of packed 'long long',
>which is relatively common; for PPC I believe it would only affect
>packed structures containing vectors, which is pretty unlikely.
>
>It is not, as far as I know, a regression.  I don't remember what the
>patch policy for 3.x.x releases is.
>  
>
I don't think we need this change for 3.4.1.  As you say, it's an ABI 
change, and we try hard to avoid those in point releases.  The policy is 
that we put in fixes for regressions only.

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com



More information about the Gcc-patches mailing list