Should ADJUST_FIELD_ALIGN honor __attribute__((packed))?

Jim Wilson wilson@specifixinc.com
Mon Apr 19 08:17:00 GMT 2004


On Sun, 2004-04-18 at 18:37, Daniel Jacobowitz wrote:
> 	* stor-layout.c (layout_decl): Check DECL_PACKED before calling
> 	ADJUST_FIELD_ALIGN.  Check maximum_field_alignment after.

This moves the maximum_field_alignment check.  This was not in the
earlier patch, and there was no explanation offered.  After a bit of
poking around, I figured out that this was needed to make pragma pack
work right.  It would have been helpful if you had explained this
yourself instead of making me look it up.

OK for head.  I believe 3.4 requires separate approval from Mark
Mitchell.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com



More information about the Gcc-patches mailing list