roll of objc-improvements-branch likely causing---

[Loren James Rittle]

In article <20030926004418.GE18975@redhat.com>,
Richard Henderson<rth@redhat.com> writes:

> On Thu, Sep 25, 2003 at 06:59:16PM -0500, Loren James Rittle wrote:
>> * config/i386/i386.h (ix86_return_in_memory): Add prototype.

> These belong in i386-protos.h, where it already exists.

> Your patch is wrong.

Hi Richard,

OK to commit this version to correct my wrong hack?

I do now see that the correct patch has to account for why a front-end
code which sees e.g. <i386/i386.h> does not also see
<i386/i386-protos.h> on this platform.  I'm not even going to ask why
tm_p.h exists (since I see that JSM already did back in Jan02 in
gcc/doc/configfiles.texi; and Zack wrote the paper explaining the ill
defined boundary between -ends)...

Zem, looks like I let you off the hook too soon. ;-(  Apparently, here
is the rule: for ports that define DEFAULT_PCC_STRUCT_RETURN to 0 on
CPUs where <cpu>_protos.h exists, you must include tm.h and tm_p.h
to use RETURN_IN_MEMORY.  I find this bizarre and not documented.

Regards,
Loren

	* config/i386/i386.h (ix86_return_in_memory): Revert my last patch.
	* objc/objc-act.c (tm_p.h): Include.

Index: gcc/config/i386/i386.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/i386/i386.h,v
retrieving revision 1.352
diff -c -r1.352 i386.h
*** gcc/config/i386/i386.h	25 Sep 2003 23:58:19 -0000	1.352
--- gcc/config/i386/i386.h	26 Sep 2003 19:32:44 -0000
***************
*** 1245,1251 ****
     should always be returned in memory.  You should instead use
     `DEFAULT_PCC_STRUCT_RETURN' to indicate this.  */
  
- int ix86_return_in_memory (tree type);
  #define RETURN_IN_MEMORY(TYPE) \
    ix86_return_in_memory (TYPE)
  
--- 1245,1250 ----
Index: gcc/objc/objc-act.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/objc/objc-act.c,v
retrieving revision 1.194
diff -c -r1.194 objc-act.c
*** gcc/objc/objc-act.c	25 Sep 2003 17:53:41 -0000	1.194
--- gcc/objc/objc-act.c	26 Sep 2003 19:32:44 -0000
***************
*** 43,48 ****
--- 43,49 ----
  #include "system.h"
  #include "coretypes.h"
  #include "tm.h"
+ #include "tm_p.h"
  #include "tree.h"
  #include "rtl.h"
  #include "expr.h"