3.3.2/3.4 PATCH: Only disable .hidden without GNU ld (PR target/12248)

Rainer Orth ro@TechFak.Uni-Bielefeld.DE
Mon Sep 15 21:15:00 GMT 2003


Jakub's proposed fix for PR target/12248 looks exactly right:

	http://gcc.gnu.org/ml/gcc-patches/2003-09/msg00686.html

Since nobody has been willing to propose it for real, here it goes.
Verified by configuring on i386-pc-solaris2.9 with GNU as: while as does
support .hidden, support is still disabled nonetheless.

I'm sorry for the breakage, but I cannot test on any GNU/Linux system.
Could somebody else please do this?

After a successful report, ok for the 3.3 branch?

On mainline, the disabling is already inside the else branch of the GNU ld
test, so testing for gnu_ld_flag is redundant.  Tested as above.

Ok for mainline?

	Rainer

-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University


Mon Sep 15 22:24:36 2003  Jakub Jelinek  <jakub@redhat.com>

	* configure.in (gcc_cv_as_hidden): Only disable if no GNU ld
	detected.
	* configure: Regenerate.
	Fixes PR target/12248.

Index: configure.in
===================================================================
RCS file: /cvs/gcc/gcc/gcc/configure.in,v
retrieving revision 1.627.2.16
diff -u -p -r1.627.2.16 configure.in
--- configure.in	9 Sep 2003 19:51:52 -0000	1.627.2.16
+++ configure.in	15 Sep 2003 20:48:45 -0000
@@ -1660,12 +1662,11 @@ changequote(,)dnl
 			fi
 		fi
 changequote([,])dnl
+	else
+		# non-GNU linkers don't seem to support .hidden yet
+		gcc_cv_as_hidden=no
 	fi
 fi
-# non-GNU linkers don't seem to support .hidden yet
-if test x"$gnu_ld_flag" = x"no"; then
-      gcc_cv_as_hidden=no
-fi
 if test x"$gcc_cv_as_hidden" = xyes; then
 	AC_DEFINE(HAVE_GAS_HIDDEN, 1,
 		[Define if your assembler supports .hidden.])


Mon Sep 15 22:48:16 2003  Rainer Orth  <ro@TechFak.Uni-Bielefeld.DE>

	* configure.in (gcc_cv_ld_hidden): Don't test gnu_ld_flag.
	* configure: Regenerate.

Index: configure.in
===================================================================
RCS file: /cvs/gcc/gcc/gcc/configure.in,v
retrieving revision 1.726
diff -u -p -r1.726 configure.in
--- configure.in	10 Sep 2003 00:13:00 -0000	1.726
+++ configure.in	15 Sep 2003 20:54:50 -0000
@@ -1855,9 +1855,7 @@ changequote([,])dnl
     fi
   else
     # non-GNU linkers don't seem to support .hidden yet
-    if test x"$gnu_ld_flag" = x"no"; then
-      gcc_cv_ld_hidden=no
-    fi
+    gcc_cv_ld_hidden=no
   fi
 fi])
 libgcc_visibility=no



More information about the Gcc-patches mailing list