Ping: unreviewed patches

Geoff Keating geoffk@geoffk.org
Mon Sep 15 01:20:00 GMT 2003


> Date: Sat, 13 Sep 2003 18:00:30 -0700
> From: Andrew Pinski <pinskia@physics.uc.edu>

> On Sunday, Sep 7, 2003, at 13:53 US/Pacific, Geoff Keating wrote:
> 
> > Andrew Pinski <pinskia@physics.uc.edu> writes:
> >
> >> Patches:
> >> <http://gcc.gnu.org/ml/gcc-patches/2003-05/msg02139.html>
> >> Unswitch Loops on PPC does not work, Fixes PR/10914 (Not mine).
> >
> > In this patch,
> >
> > !    further.  If ALLOW_CC_MODE, allow the resulting condition compare
> > !    CC mode register.  */
> >
> > I'd appreciate it if this could be changed to be a sentence.
> >
> > !    If ALLOW_CC_MODE, allow the condition returned to compare CC mode
> > !    register.  */
> >
> > Here, too, better grammar would be helpful.  (I'd suggest better
> > wording, but the originals don't make enough sense for me to know
> > what it was supposed to mean.)
> >
> > Otherwise, this patch is OK.
> 
> 
> I just got a working mainline (Thank you, Keating).
> Since this patch was okayed with a conditional of rewording this comment
> Would does the following sound right:
> If ALLOW_CC_MODE is non-zero, allow the condition returned to a compare 
> to a  CC mode register.

There's a verb missing.  '... allow the condition returned to X a
compare to a CC mode register'.

Suitable choices for X include 'be', 'create', 'remove', 'prevent'...

-- 
- Geoffrey Keating <geoffk@geoffk.org>



More information about the Gcc-patches mailing list