[C++ PATCH]: Fix 11595

Jason Merrill jason@redhat.com
Sat Sep 6 15:21:00 GMT 2003


On Sat, 06 Sep 2003 16:27:43 +0200, Steven Bosscher <s.bosscher@student.tudelft.nl> wrote:

> *************** define_label (location_t location, tree 
> *** 4977,4985 ****
>   	  ent->binding_level = current_binding_level;
>   	}
>         check_previous_gotos (decl);
> -       POP_TIMEVAR_AND_RETURN (TV_NAME_LOOKUP, decl);
>       }
> !   timevar_pop (TV_NAME_LOOKUP);
>   }
>   
>   struct cp_switch
> --- 4973,4981 ----
>   	  ent->binding_level = current_binding_level;
>   	}
>         check_previous_gotos (decl);
>       }
> ! 
> !   POP_TIMEVAR_AND_RETURN (TV_NAME_LOOKUP, decl);
>   }

The use of POP_TIMEVAR_AND_RETURN seems unnecessary here.  In fact, it's
not clear to me why it would ever be useful to combine the two operations.
Gaby?

Just write

  timevar_pop (TV_NAME_LOOKUP);
  return decl;

OK with that change.

Jason



More information about the Gcc-patches mailing list