[patch,m68k] Get rid of #ifdef MOTOROLA
Bernardo Innocenti
bernie@develer.com
Mon Nov 10 19:54:00 GMT 2003
Gunther Nikl wrote:
> On Sat, Nov 08, 2003 at 09:10:50AM +0100, Bernardo Innocenti wrote:
>
>>Otherwise, I could do this in m68k.c:
>>
>> /* Force a truth value for MOTOROLA. */
>> #ifdef MOTOROLA
>> # undef MOTOROLA
>> # define MOTOROLA 1
>> #else
>> # define MOTOROLA 0
>> #endif
>
> I believe that is necessary. Doing it that way ensures that the 0/1
> change is only done for m68k.c. This means that no header defining
> MOTOROLA has to/should be changed right now.
Ok, I'll do that. For you, it should be ok both on m68k-linux and
m68k-amigaos even without this change.
>>You can. I'd suggest converting m68k.md later, because it's already
>>a massive patch now, and the place where it makes most sense to do
>>this change is m68k.c anyway.
>
> I realized later that only changing m68k.c is safe and that converting
> m68k.md can be done in a separate step. I am going to test the patch.
Thank you!
>>%O replaces an opcode with its assembler specific version. It shouldn't
>>affect MIT syntax output. On the countrary, we could take advantage of
>>it to merge more instructions: those where the only difference is in the
>>opcode name.
>
> Does any m68k port really use %O?
Only those using the SGS assembler and the HPUX asm. Look for the definition
of ASM_OUTPUT_OPCODE in sgs.h and hp320.h.
Of course I hope to get rid of that old cruft as soon as possible ;-)
--
// Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/ http://www.develer.com/
More information about the Gcc-patches
mailing list