argument numbering for the tree inliner

Geoff Keating geoffk@geoffk.org
Fri Nov 7 00:21:00 GMT 2003


Mike Stump <mrs@apple.com> writes:

> This change restores argument numbering to the tree inliner.
> Previously, they had been numbered, but when the tree inliner went
> live, this functionality wasn't implemented at that time.
> 
> tested c and objc on powerpc-apple-darwin6.3, no regressions.

This is OK, except that:

> *** ./testsuite/gcc.dg/warn-1.c.~1~	Mon Apr 28 16:34:40 2003
> --- ./testsuite/gcc.dg/warn-1.c	Wed Nov  5 15:51:46 2003
> ***************
> *** 5,18 ****
>   
>   static void foo (p)
>        int p;
> ! {	/* { dg-warning "passing arg of" } */
>   }
>   
> ! static void bar (void)
>   {
>     void *vp;
>   
>     foo (vp);	/* { dg-warning "" } */
>   }
> - 
> - void (*tourist_guide[]) (void) = { &bar };
> --- 5,16 ----
>   
>   static void foo (p)
>        int p;
> ! {	/* { dg-warning "passing arg 1 of" } */
>   }
>   
> ! void bar (void)
>   {
>     void *vp;
>   
>     foo (vp);	/* { dg-warning "" } */
>   }

You've changed the structure of the testcase for no apparent reason.
Please don't do that.  It should be sufficient to just change the text
of the warning.

-- 
- Geoffrey Keating <geoffk@geoffk.org>



More information about the Gcc-patches mailing list