[PATCH m68k] Fix TRANSFER_FROM_TRAMPOLINE for -Werror

Gunther Nikl gni@gecko.de
Tue Nov 4 13:40:00 GMT 2003


On Tue, Nov 04, 2003 at 10:55:20AM +0100, Andreas Schwab wrote:
> Bernardo Innocenti <bernie@develer.com> writes:
> 
> > Gunther Nikl wrote:
> >
> >>  {								\
> >> -  register char *a0 asm ("%a0");				\
> >> +  register char *a0 asm ("%a0") = a0;				\
> >
> > This is... err... ugly.  Couldn't you use __attribute__((used))
> > instead?
> 
> Note that TRANSFER_FROM_TRAMPOLINE is actually unused since the rewrite of
> the trampoline support on m68k 7 years ago:
> 
> <http://gcc.gnu.org/cgi-bin/cvsweb.cgi/old-gcc/config/m68k/m68k.h?rev=1.53&content-type=text/x-cvsweb-markup&cvsroot=gcc>
> 
> The definition is only left in for backward compatibility with old object
> files, so I'd vote for removing it completely.

  I missed that comment even if its directly above TRANSFER_FROM_TRAMPOLINE.
  If its possible to get rid of all warnings in a clean way, I would vote
  for keeping TRANSFER_FROM_TRAMPOLINE. If thats not possible, then it should
  be removed.
  If -Werror comes back someday, how shall one cope with ignored attributes
  like eg. "used" or "hidden"?

  Gunther



More information about the Gcc-patches mailing list