[tree-ssa] Gimple vs builtins

law@redhat.com law@redhat.com
Fri Mar 14 15:53:00 GMT 2003


In message <87vfymyc9g.fsf@egil.codesourcery.com>, Zack Weinberg writes:
 >law@redhat.com writes:
 >
 >>  >Does this block of text really need to be duplicated ahead of every
 >>  >simplify_builtin_foobar function?
 >>
 >> I'd prefer to have it rather than something like
 >> "See XXX for documentation ..."   
 >
 >I was thinking more like have it once before the entire set:  "All the
 >simplify_builtin_foobar functions return ..."
I really don't like that -- comments belong with their code, not 8 functions
(and many pages of code) earlier.

We have the convention that each function has a comment describing its
purpose, arguments and return value.  I strongly believe that convention
is wise and that it should be followed unless there's a very good reason
not to.

jeff



More information about the Gcc-patches mailing list