Cleanup etags generation (Was Re: Ping: etags patch)

[Andreas Jaeger]

Tom Tromey <tromey@redhat.com> writes:

> This hasn't been reviewed:
>
>     http://gcc.gnu.org/ml/gcc-patches/2003-02/msg01225.html

This patches introduces a duplicate treelang.tags and is also
problematic in cp/Make-Lang.in since we now have both these rules:

c++.tags: force
	cd $(srcdir)/cp; etags *.c *.h

# Update the tags table.
cp/TAGS: force
	cd $(srcdir)/cp ;			\
	etags --no-globals -l c *.c *.h ../*.c ../*.h;

.PHONY: cp/TAGS

I assume that the later (older) rule can get removed now.  Is the
appended patch for cp and treelang ok to commit?

I'm bootstrapping on i686-linux-gnu now.  

A make TAGS was successfull - but I got this error message (introduced
by Tom's patch):

mv -f c-parse.[ch] =*.[chy] tmp-tags;                        \
etags *.y *.h *.c $incs;                                     \
mv tmp-tags/* .;                                             \
rmdir tmp-tags)
mv: cannot stat `=*.[chy]': No such file or directory

What's the purpose of =*.[chy]?  I do not see a reason for such files
at all.

Andreas

For cp:
2003-03-13  Andreas Jaeger  <aj@suse.de>

	* Make-lang.in (cp/TAGS): Remove.

For treelang:
2003-03-13  Andreas Jaeger  <aj@suse.de>

	* Make-lang.in (treelang.tags): Remove duplicate entry.


============================================================
Index: gcc/cp/Make-lang.in
--- gcc/cp/Make-lang.in	12 Mar 2003 04:18:34 -0000	1.139
+++ gcc/cp/Make-lang.in	13 Mar 2003 06:51:20 -0000
@@ -274,12 +274,3 @@ cp/optimize.o: cp/optimize.c $(CXX_TREE_
 cp/mangle.o: cp/mangle.c $(CXX_TREE_H) $(TM_H) toplev.h real.h
 
 cp/parser.o: cp/parser.c $(CXX_TREE_H) $(TM_H) diagnostic.h gt-cp-parser.h output.h
-#
-# These exist for maintenance purposes.
-
-# Update the tags table.
-cp/TAGS: force
-	cd $(srcdir)/cp ;			\
-	etags --no-globals -l c *.c *.h ../*.c ../*.h;
-
-.PHONY: cp/TAGS
============================================================
Index: gcc/treelang/Make-lang.in
--- gcc/treelang/Make-lang.in	13 Mar 2003 04:57:07 -0000	1.16
+++ gcc/treelang/Make-lang.in	13 Mar 2003 06:51:20 -0000
@@ -312,15 +312,6 @@ treelang.wc: force
 
 #
 
-# Update the tags table for emacs find label (alt-.) function
-TAGS: treelang.tags
-
-.PHONY: treelang.tags
-
-treelang.tags:
-	cd $(srcdir)/treelang;						\
-	etags -l c ${TREE_SOURCE}
-
 .PHONY: treelang.html
 
 treelang.html:

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj