don't assume pointer cast to unsigned long is a valid initializer

Alexandre Oliva aoliva@redhat.com
Mon Mar 3 19:34:00 GMT 2003


On Mar  3, 2003, Geoff Keating <geoffk@geoffk.org> wrote:

> I took a partial survey, and I believe that this code should work on:

> - All mips-elf platforms (due to R_MIPS_64)

It doesn't work with EABI, as Richard Sandiford pointed out,
confirming my recollection that it didn't really work on mips64-elf
except when sizeof(long)==sizeof(void*).  Since this patch introduces
a regression, I propose that we revert it according to the
patch-reversal rules, and on the grounds that it didn't follow the
rules for modifying testcases.

> of the platforms where it's not identical to 20011114-1.c.  I couldn't
> find any platform where this functionality should *not* work, so
> haven't added them into a .x file.

I bet it won't work on h8300-elf, since it seems to have 16-bit
pointers and 32-bit longs.  There are probably others like this.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer



More information about the Gcc-patches mailing list