PATCH: Enable MASK_SSE for -msse2

Michael Meissner gcc-pat@the-meissners.org
Wed Jun 25 21:42:00 GMT 2003


On Tue, Jun 24, 2003 at 10:52:04PM -0700, H. J. Lu wrote:
> On Tue, Jun 24, 2003 at 08:30:37PM -0700, Richard Henderson wrote:
> > On Tue, Jun 24, 2003 at 05:59:11PM -0700, H. J. Lu wrote:
> > > It is more than just MASK_SSE and MASK_SSE2. Do you want a patch
> > > to fix them first?
> > 
> > Yes please.  That'll make the PNI patch much smaller.
> > 
> 
> Here it is. There is no regression.
> 
> 
> H.J.

> 2003-06-24  H.J. Lu <hongjiu.lu@intel.com>
> 
> 	* config/i386/i386.c (MASK_SSE1): Removed.
> 	(MASK_SSE164): Removed.
> 	(MASK_SSE264): Removed.
> 	(bdesc_2arg): Replace MASK_SSE1 with MASK_SSE. Replace
> 	MASK_SSE164 with MASK_SSE | MASK_64BIT. Replace MASK_SSE264
> 	with MASK_SSE2 | MASK_64BIT.
> 	(bdesc_1arg): Likewise.
> 	(ix86_init_mmx_sse_builtins): Likewise.
> 
> 	* config/i386/i386.h (TARGET_SSE): Remove MASK_SSE2.
> 	(TARGET_SWITCHES): Enable both MASK_SSE and MASK_SSE2 for
> 	-msse2.
> 
> --- gcc/config/i386/i386.c.mask	2003-06-24 15:24:27.000000000 -0700
> +++ gcc/config/i386/i386.c	2003-06-24 21:39:37.000000000 -0700
> @@ -12771,25 +12771,20 @@ struct builtin_description
>    const unsigned int flag;
>  };
>  
> -/* Used for builtins that are enabled both by -msse and -msse2.  */
> -#define MASK_SSE1 (MASK_SSE | MASK_SSE2)
> -#define MASK_SSE164 (MASK_SSE | MASK_SSE2 | MASK_64BIT)
> -#define MASK_SSE264 (MASK_SSE2 | MASK_64BIT)

As a minor comment, may I suggest using MASK_SSE1_64 instead of MASK_SSE164,
and MASK_SSE2_64 with MASK_SSE264.  It is much clear that you mean the 64 bit
version of SSE1/SSE2 instead of the 164th and 264th version of SSE.

-- 
Michael Meissner
email: gnu@the-meissners.org
http://www.the-meissners.org



More information about the Gcc-patches mailing list