[PATCH] Empty BINCL/EINCL

Geoff Keating geoffk@geoffk.org
Fri Jun 20 19:30:00 GMT 2003


Hi Devang,

+ static void emit_bincl_stab             PARAMS ((const char *));

For new code, ISO C should be used, so no PARAMS, and no old-style
function definitions.

+ /* If zero then there is no pending BINCL */

This comment needs to be a full sentence, like:

/* If zero then there is no pending BINCL.  */

and there are a few more like this:

+   enum binclstatus bincl_status;      /* Keep track of lazy bincl */
+   const char *pending_bincl_name;     /* Name of bincl */
+   struct dbx_file *prev;              /* Chain to traverse all pending bincls */
+   /* Find first pending bincl */
+   /* Now emit all bincls */
+ 	  /* Update file number and status */

This comment:

+   /* Do not assign file number now. Delay it until we actually emit BINCL.  */

hould have two spaces after the '.'.

With these minor formatting changes, the patch is OK.

-- 
- Geoffrey Keating <geoffk@geoffk.org>



More information about the Gcc-patches mailing list