[patch] Fix PR debug/4252

Neil Booth neil@daikokuya.co.uk
Tue Jun 17 21:03:00 GMT 2003


Neil Booth wrote:-

> Bob Abeles wrote:-
> 
> > Yes, that improves it:
> > 
> > 2003-06-17  Robert Abeles  <rabeles@archaelogic.com>
> > 
> > 	PR debug/4252
> > 	* c-opts.c (c_common_handle_option): Pass -fdump argument suffix
> > 	to dump_switch_p().
> > 	* tree-dump.c (dump_switch_p): Handle -fdump argument suffix.
> 
> Sorry, I should have been more clear.  The repeating dump- in the
> static strings is pointless.  You should remove that, and check for
> any other callers (I'm sure there are some) and other uses of said
> static strings, and confirm that you've bootstrapped the result.
> All this skip_leading_substring junk should not be needed.

I've had a look at this and dump_switch_p seems to be trying far too
hard, and so the change starts to get quite large.  You can leave this to
me if you like; I'll get to it in the next few days if you don't.

Do you have a copyright assignment on file?  If you intend to contribute
much in future, you should probably get one.

Neil.



More information about the Gcc-patches mailing list