Addendum -- [BUG REPORT + PATCH] -Wpadded on powerpc

David Taylor dtaylor@emc.com
Tue Jun 10 13:31:00 GMT 2003


> From: Jim Wilson <wilson@tuliptree.org>
> Date: 09 Jun 2003 22:34:48 -0700
> 
> On Mon, 2003-06-09 at 20:07, David Taylor wrote:
> > Thanks.  Alas, that patch was incomplete.  Here's a fuller one...
> 
> The problem was obvious when I did a powerpc-elf cross build.
> 
> You really should test your patches before submitting them.  And I
> really should test patches that come from people who aren't regular gcc
> contributors.  I installed the patch, so it is ultimately my fault.

I actually did test it; but somehow I screwed up.  I have a number of
sandboxes and all I can figure is that when I checked it the next day,
I checked the wrong sandbox.

As I'm maintaining GCC for EMC, I'm hoping to become a semi regular
contributor.

I appreciate you taking the time to commit the patch and I'm sorry
this happened.

> Here is what I checked in to fix the problem.  This is the part of your
> patch that wasn't already installed, along with a ChangeLog entry.  I
> still have tests running, hopefully no more problems show up.

Sorry for not sending a ChangeLog for the addendum; thanks for
creating one.  When I saw your email; I did a quick diff of what was
committed; realized it was the incomplete version; and wanted to get
the rest of the patch out quickly.

> Jim

David



More information about the Gcc-patches mailing list