Unreviewed cygwin/mingw dllimport patch for PRs 5287. 7910, 11021

Mark Mitchell mark@codesourcery.com
Tue Jun 10 07:13:00 GMT 2003


On Sun, 2003-06-08 at 13:57, Danny Smith wrote:
> This patch:
> 
> http://gcc.gnu.org/ml/gcc-patches/2003-05/msg02391.html
> 
> and updated documentation:
> 
> http://gcc.gnu.org/ml/gcc-patches/2003-05/msg02515.html
> 
> fix several open mingw/cygwin PRS (C++/5287,C++/7910,C++/11021)
> on trunk, and adds testcases.
> 
> Could someone please review?

This patch looks good to me, and I would very much like to have those
regressions closed.

Chris Faylor knows this code better than I, but if he does not have any
objections within a week, please check in your change.

!       else if (TREE_CODE (TREE_TYPE (decl)) == METHOD_TYPE
! 	       && DECL_VIRTUAL_P (decl))
!         {
!           return 0;
!         }

That should have no braces; the GNU coding standards say a single
statement needn't be enclosed in braces.

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com



More information about the Gcc-patches mailing list