[patch] Re: reload vs adds with clobbers

Jim Wilson wilson@tuliptree.org
Sat Jun 7 07:01:00 GMT 2003


I think you want a comment explaining why the !N is there.  Otherwise it 
is an obvious bug, and the next person will want to fix it by removing 
the !N alternative.

Curious that you set the length to 2 instead of 0, but maybe there is an 
undocumented reason why you had to do that also?  If so, if probably 
should be in a comment also.

Otherwise, this is OK, unless Geoff wants to overrule me as maintainer 
of the xstormy16 port.

Jim



More information about the Gcc-patches mailing list