RFA: Fix pch/system-1.c failures for systems with non-trivial BUILD_VA_LIST_TYPE
Neil Booth
neil@daikokuya.co.uk
Tue Jun 3 22:38:00 GMT 2003
Richard Henderson wrote:-
> On Tue, Jun 03, 2003 at 11:50:49AM +0100, Joern Rennecke wrote:
> > Neil Booth wrote:
> > > Comparing strings to <built-in> is always a bug. Is your whole patch
> > > really the right fix?
> >
> > Setting input_location.file to NULL has the effect that declarations
> > are recorded as coming from the input file "<built-in>".
>
> Perhaps this is the bug? Perhaps this should be left as NULL,
> but frobbed to <built-in> only when emitting diagnostics?
Maybe. But <built-in> is internationalized in cpplib, and should be
in the front-end too if it isn't already. We shouldn't be comparing
strings like that.
Jason fixed this a few weeks back for C++.
Neil.
More information about the Gcc-patches
mailing list